Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mnemonic phrase popup on mobile #868

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: mnemonic phrase popup on mobile #868

merged 1 commit into from
Jan 24, 2023

Conversation

j-bitmaker
Copy link
Contributor

@j-bitmaker j-bitmaker commented Jan 16, 2023 •
edited
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • fixed popup with key words after register for mobile devices (showed all 12 words)

Other comments:

...

@shpingalet007 shpingalet007 changed the title pkview mobile fix: mnemonic phrase popup on mobile Jan 24, 2023
@shpingalet007 shpingalet007 added contribution type: 🐛 fix Something isn't working and removed deploy.dev labels Jan 24, 2023
shpingalet007
shpingalet007 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked

@shpingalet007 shpingalet007 merged commit e2a8d1d into pocketnetteam:master Jan 24, 2023
MoMentalochka pushed a commit to MoMentalochka/pocketnet.gui-my that referenced this pull request Jan 25, 2023
@j-bitmaker @MoMentalochka
fix: mnemonic phrase popup on mobile (pocketnetteam#868)
352ad9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgithubprofile maxgithubprofile maxgithubprofile approved these changes

@shpingalet007 shpingalet007 shpingalet007 approved these changes

Assignees

@j-bitmaker j-bitmaker

Labels
contribution type: 🐛 fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-bitmaker @maxgithubprofile @shpingalet007