Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: invitation to install pwa application on ios #819

Merged
merged 2 commits into from
Dec 15, 2022
Merged

patch: invitation to install pwa application on ios #819

merged 2 commits into from
Dec 15, 2022

Conversation

maxgithubprofile
Copy link
Collaborator

@maxgithubprofile maxgithubprofile commented Dec 15, 2022 •
edited by shpingalet007
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine, or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable, and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • Change variable name
  • Change page URL path

Other comments:

Some patches related to #805.

@auto-assign auto-assign bot requested a review from shpingalet007 December 15, 2022 09:17
@maxgithubprofile maxgithubprofile changed the title Change name var fix: change title variable Dec 15, 2022
@shpingalet007 shpingalet007 changed the title fix: change title variable patch: invitation to install pwa application on ios Dec 15, 2022
@shpingalet007 shpingalet007 added the contribution type: 🧩 patch Pull request that is considered as patch label Dec 15, 2022
@shpingalet007 shpingalet007 added this to the Next release milestone Dec 15, 2022
shpingalet007
shpingalet007 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked

@shpingalet007 shpingalet007 merged commit e5d6d96 into master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shpingalet007 shpingalet007 shpingalet007 approved these changes

Assignees

@maxgithubprofile maxgithubprofile

Labels
contribution type: 🧩 patch Pull request that is considered as patch
Projects
Team Management
Status: ✅ Done
Milestone
Next release
Development

Successfully merging this pull request may close these issues.
2 participants
@maxgithubprofile @shpingalet007