Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apps download popup not showing #772

Merged
merged 2 commits into from
Nov 22, 2022
Merged

fix: apps download popup not showing #772

merged 2 commits into from
Nov 22, 2022

Conversation

LEV7n
Copy link
Contributor

@LEV7n LEV7n commented Nov 22, 2022 •
edited by shpingalet007
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine, or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable, and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • Fix banner with app's download invitation not showing up

Other comments:

Described banner was firstly introduced in PR #565

@shpingalet007 shpingalet007 changed the title Fix: App Download Popups appearing fix: apps download popup not showing Nov 22, 2022
@shpingalet007 shpingalet007 added the contribution type: 🐛 fix Something isn't working label Nov 22, 2022
@shpingalet007 shpingalet007 added this to the Next release milestone Nov 22, 2022
shpingalet007
shpingalet007 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked. However, @LEV7n, consider to not use master branch for PR's. Thanks!

@shpingalet007 shpingalet007 merged commit ffb0cd6 into pocketnetteam:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shpingalet007 shpingalet007 shpingalet007 approved these changes

@maxgithubprofile maxgithubprofile Awaiting requested review from maxgithubprofile

Assignees

@LEV7n LEV7n

Labels
contribution type: 🐛 fix Something isn't working
Projects
Team Management
Status: ✅ Done
Milestone
Release 0.8.34
Development

Successfully merging this pull request may close these issues.
2 participants
@LEV7n @shpingalet007