Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: top ranked videos instead of most commented #745

Merged
merged 1 commit into from
Nov 10, 2022
Merged

patch: top ranked videos instead of most commented #745

merged 1 commit into from
Nov 10, 2022

Conversation

MoMentalochka
Copy link
Contributor

@MoMentalochka MoMentalochka commented Nov 7, 2022 •
edited by shpingalet007
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • [Change main lenta request]

shpingalet007
shpingalet007 requested changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can't be merged currently

  • js/satolist.js has linting changes

@shpingalet007 shpingalet007 added the contribution type: 🧩 patch Pull request that is considered as patch label Nov 8, 2022
@shpingalet007 shpingalet007 added this to the Next release milestone Nov 10, 2022
shpingalet007
shpingalet007 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked

@shpingalet007 shpingalet007 changed the title patch:lenta-request patch: top ranked videos instead of most commented Nov 10, 2022
@shpingalet007 shpingalet007 merged commit 46312c6 into pocketnetteam:master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shpingalet007 shpingalet007 shpingalet007 approved these changes

@maxgithubprofile maxgithubprofile Awaiting requested review from maxgithubprofile

Assignees

@MoMentalochka MoMentalochka

Labels
contribution type: 🧩 patch Pull request that is considered as patch
Projects
Team Management
Status: ✅ Done
Milestone
Release 0.8.22
Development

Successfully merging this pull request may close these issues.
2 participants
@MoMentalochka @shpingalet007