Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: top menu not showing up in old browsers #743

Merged
merged 3 commits into from
Nov 7, 2022
Merged

fix: top menu not showing up in old browsers #743

merged 3 commits into from
Nov 7, 2022

Conversation

maxgithubprofile
Copy link
Collaborator

@maxgithubprofile maxgithubprofile commented Nov 7, 2022 •
edited by shpingalet007
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine, or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable, and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • 6037f0b - Add fallback for CSS3 max(...) via @supports.
  • 451edfd - Set min-height: 65px for case when height can't be calculated.

Other comments:

All changes in this PR are related to #menu .menuWrapper element.

This PR closes #741

@auto-assign auto-assign bot requested a review from shpingalet007 November 7, 2022 12:51
@shpingalet007 shpingalet007 changed the title fix07-11 fix: top menu doesn't shows up on some devices Nov 7, 2022
@shpingalet007 shpingalet007 added the contribution type: 🐛 fix Something isn't working label Nov 7, 2022
@shpingalet007 shpingalet007 added this to the Next release milestone Nov 7, 2022
@shpingalet007 shpingalet007 force-pushed the dfix07-11 branch 3 times, most recently from e336689 to f9c618f Compare November 7, 2022 14:52
shpingalet007
shpingalet007 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked

Bug fix confirmed on

  • MIUI 10.1.2
  • Google Chrome 69.0.3497.100

@shpingalet007 shpingalet007 changed the title fix: top menu doesn't shows up on some devices fix: top menu not showing up in old browsers Nov 7, 2022
@shpingalet007 shpingalet007 merged commit 5fe7443 into master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shpingalet007 shpingalet007 shpingalet007 approved these changes

Assignees

@maxgithubprofile maxgithubprofile

Labels
contribution type: 🐛 fix Something isn't working
Projects
Team Management
Status: ✅ Done
Milestone
Release 0.8.22
Development

Successfully merging this pull request may close these issues.

Top menu doesn't shows up on some devices
2 participants
@maxgithubprofile @shpingalet007