Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store images on peertube servers #723

Merged
merged 18 commits into from
Jan 24, 2023
Merged

feat: store images on peertube servers #723

merged 18 commits into from
Jan 24, 2023

Conversation

julien-rg
Copy link
Contributor

@julien-rg julien-rg commented Oct 28, 2022

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

When uploading an image, now tries to upload on a Peertube server.
If it does not work, it fallbacks to Imgur.
During app initialization, a random Peertube is chosen from the list of servers (returned by the "roys" proxy call).

Other comments:

Currently, the Peertube authentication is used with username and password: "test_bastyon" (see app.js / line 124).
So we need to make sure each Peertube server has this account created with the correct password.

@julien-rg julien-rg changed the title Peertube server: Update image upload response Images: Switch to Peertube servers Oct 31, 2022
@shpingalet007 shpingalet007 changed the title Images: Switch to Peertube servers feat: store images on peertube servers Nov 5, 2022
@shpingalet007 shpingalet007 added this to the Planned release milestone Nov 5, 2022
@shpingalet007
Copy link
Collaborator

Consider naming your PR branches with better name next time. Using master branch for pushing pulls is complicating the work with the git branches tree.

@shpingalet007 shpingalet007 merged commit eab6a3a into pocketnetteam:master Jan 24, 2023
MoMentalochka pushed a commit to MoMentalochka/pocketnet.gui-my that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution type: ✨ feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants