Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: two new video servers #713

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

zanhesl
Copy link
Contributor

@zanhesl zanhesl commented Oct 17, 2022

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • Added new servers: peertube27, peertube28, peertube29 and peertube30

Other comments:

...

@shpingalet007 shpingalet007 changed the title New video servers patch: two new video servers Oct 20, 2022
peertube29 and peertube30, both hezner
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The branch is not named well (27-28-servers). 29-30-servers could be better documented
  • There were commits from patch: two new video servers #707 PR. Rebased onto master 7d64f37
  • Title wasn't filled as described in template. Fixed, consider this as a PATCH

@shpingalet007 shpingalet007 merged commit ed22e7b into pocketnetteam:master Oct 20, 2022
zanhesl added a commit to zanhesl/pocketnet.gui that referenced this pull request Oct 24, 2022
* peertube29.pocketnet.app
* peertube30.pocketnet.app
@shpingalet007 shpingalet007 added this to the Next release milestone Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants