Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: set java 11 for android build workflow #704

Merged
merged 1 commit into from
Oct 6, 2022
Merged

workflow: set java 11 for android build workflow #704

merged 1 commit into from
Oct 6, 2022

Conversation

julien-rg
Copy link
Contributor

@julien-rg julien-rg commented Oct 6, 2022 •
edited by shpingalet007
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • Update Java version to 11 to build Android app in Git workflow.

Other comments:

Related to build-app-android job 5208181916 located in action run 3191624447.

DebugInfo

⬇️ Download logs

@shpingalet007 shpingalet007 changed the title Git Workflow: Update to Java 11 for Android build patch: set java 11 for android build workflow Oct 6, 2022
@shpingalet007 shpingalet007 added the contribution type: 🧩 patch Pull request that is considered as patch label Oct 6, 2022
shpingalet007
shpingalet007 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality checked

@shpingalet007 shpingalet007 merged commit c1cebd0 into pocketnetteam:master Oct 6, 2022
@shpingalet007 shpingalet007 changed the title patch: set java 11 for android build workflow workflow: set java 11 for android build workflow Oct 6, 2022
@shpingalet007
Copy link
Collaborator

Used invalid merge title tag patch instead of workflow in c1cebd0. Changed that in PR, btw the commit will remain as-is

This was referenced Oct 10, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shpingalet007 shpingalet007 shpingalet007 approved these changes

@maxgithubprofile maxgithubprofile Awaiting requested review from maxgithubprofile

Assignees

@julien-rg julien-rg

Labels
contribution type: 🧩 patch Pull request that is considered as patch
Projects
Team Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-rg @shpingalet007