Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recommendations by tags, refactor: remove unused resources, refactor: remove owl gallery plugin #661

Merged
merged 119 commits into from
Sep 20, 2022
Merged

feat: recommendations by tags, refactor: remove unused resources, refactor: remove owl gallery plugin #661

merged 119 commits into from
Sep 20, 2022

Conversation

maxgithubprofile
Copy link
Collaborator

@maxgithubprofile maxgithubprofile commented Sep 2, 2022 •
edited by shpingalet007
Loading

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Other comments:

Need to rebuild chat

j-bitmaker and others added 21 commits August 24, 2022 12:23
format init
f9f4657
format
ab7a38e
dividing sections pkoin
8ab7aec
Merge branch 'master' of https://github.com/pocketnetteam/pocketnet.gui…
74ad031 
… into pkoin_update
boost and pkoin conditions
191bd72
fix mobile; article & video click
c18230f
@maxgithubprofile
remove unused images, add request animation frame
3db3a6a
@maxgithubprofile
remove sounds, modify miniimze script
b9298d6
@shpingalet007
Merge remote-tracking branch 'origin/master' into pkoin_update
0035762 
Resolve conflicts between master at f3b42c2
@maxgithubprofile
Update minimize.js
87f595f
@j-bitmaker @shpingalet007
define boost in init
aa2793b 
Co-Authored-By: j-bitmaker <51827834+j-bitmaker@users.noreply.github.com>
@j-bitmaker @shpingalet007
true
207ec75 
Co-Authored-By: j-bitmaker <51827834+j-bitmaker@users.noreply.github.com>
@j-bitmaker @shpingalet007
settings_comments_order
49aa23b 
Co-Authored-By: j-bitmaker <51827834+j-bitmaker@users.noreply.github.com>
@j-bitmaker @shpingalet007
sorting default value
b151fa7 
Co-Authored-By: j-bitmaker <51827834+j-bitmaker@users.noreply.github.com>
@shpingalet007
Fix localization issue occurred after rebase
5135375
remove pkoin; boost fix
6a2386c
Merge branch 'pkoin_update' of https://github.com/j-bitmaker/pocketne…
4c728ec 
…t.gui into pkoin_update
@maxgithubprofile
recommendation algoritm
11c3eb4
@maxgithubprofile
Update satolist.js
753048a
@maxgithubprofile
remove owl gallery
3b4ec2f
@maxgithubprofile
Update functions.js
2acde41
@auto-assign auto-assign bot requested a review from shpingalet007 September 2, 2022 11:27
shpingalet007
shpingalet007 approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted with reservations

  1. Commits history is not self-described
  2. Chat and Peertube player must be compiled in a separate pull request
  3. Tasks must be separated from each other to do the code checks

Approved under @maxgithubprofile responsibility.

@shpingalet007 shpingalet007 merged commit 40f1def into master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shpingalet007 shpingalet007 shpingalet007 approved these changes

Assignees

@maxgithubprofile maxgithubprofile

Labels
contribution type: ✨ feature New feature or request
Projects
Team Management
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxgithubprofile @shpingalet007