Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch: transferring configs to files, update package.json #1176

Merged
merged 33 commits into from
Jan 24, 2024

Conversation

maxgithubprofile
Copy link
Collaborator

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • The PR has self-explained commits history.
  • The code is mine or it's from somewhere with an Apache-2.0 compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new classes, methods, I provide a valid use case for all of them.

Changes:

  • [...]

Other comments:

...

Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More NPM fixes can be applied, need to discuss them before merging

@shpingalet007 shpingalet007 added deploy.dev contribution type: 🧩 patch Pull request that is considered as patch labels Jan 23, 2024
Copy link
Collaborator

@shpingalet007 shpingalet007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security fixes are confirmed now, everything is ok

@shpingalet007 shpingalet007 merged commit b5ad0d6 into master Jan 24, 2024
LEV7n pushed a commit to LEV7n/pocketnet.gui that referenced this pull request Jan 26, 2024
…1176)

* Many fixes
* Configurations are moved to JSON
* NPM security patches applied

---------

Co-authored-by: Pavel Vernigorov <22795961+shpingalet007@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution type: 🧩 patch Pull request that is considered as patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants