Fixing Issue - 1669 - PeoplePicker returns no results with webAbsoluteUrl and ensureUser

[NishkalankBezawada]

Q	A
Bug fix?	[x]
New feature?	[ ]
New sample?	[ ]
Related issues?	fixes #1669

What's in this Pull Request?

Fixing issue - 1669 - PeoplePicker returns no results with webAbsoluteUrl and ensureUser

Problem statement

When setting webAbsoluteUrl prop to a different site and property to ensureUser = true, results are expected to be returned.
But, No results are fetched, If both the webAbsoluteUrl prop is pointing to a different site than the current one, and ensureUser is set to true, no results are returned in the picker. Instead, the console shows the error: PeopleSearchService::searchTenant: error occured while fetching the users.

A deeper error says Cannot read properties of undefined (reading 'push'), which I've tracked down to PeopleSearchService.ensureUser:295. The object cachedLocalUsers assumes it already contains the webAbsoluteUrl as a key but it does not.

Solution

When checked, in the method ensureUser, the user object is pushed into this.cachedLocalUsers. But this is empty because the user is given webAbsoluteUrl to fetch the users from other site collection, for which it is erroring out as Cannot read properties of undefined (reading push) as shown in the below figure.

By checking if this.cachedLocalUsers and initializing it as empty array (as below), this is working as expected.

Screenshot with working example

Thanks,
Nishkalank Bezawada

[NishkalankBezawada]

Hello @michaelmaillot @joelfmrodrigues

Kindly review this PR and let me know your comments.

Thanks,
Nishkalank

[michaelmaillot]

Thanks @NishkalankBezawada, we'll review this PR shortly!

[michaelmaillot]

PR merged, thank you!