Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show files on folder explorer control #1502

Merged
merged 2 commits into from
May 13, 2023

Conversation

ayoubqrt
Copy link
Contributor

@ayoubqrt ayoubqrt commented Apr 3, 2023

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

In the FolderExplorer control, show files included in folders (optional)

@joelfmrodrigues
Copy link
Collaborator

@ayoubqrt many thanks for your contribution.
Could you please resolve the code conflicts? Please let us know if you need any help with that.

@ayoubqrt
Copy link
Contributor Author

ayoubqrt commented May 3, 2023

@joelfmrodrigues it's resolved 😄

@joelfmrodrigues joelfmrodrigues merged commit 1d7a4c5 into pnp:dev May 13, 2023
@joelfmrodrigues
Copy link
Collaborator

@ayoubqrt many thanks for this, everything seems to be working fine. Extremely sorry for the huge delay at my end, had a lot of work recently and was unable to work on this...
While testing it, I noticed that the file icon is always the same. Would you be interested in submitting a new improvement to improve this? Maybe using the FileTypeIcon control?
https://pnp.github.io/sp-dev-fx-controls-react/controls/FileTypeIcon/

@joelfmrodrigues joelfmrodrigues added this to the 3.15.0 milestone May 13, 2023
@ayoubqrt ayoubqrt deleted the feat/show-files-folder-explorer branch December 26, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants