Fix - Wrong preselected user in dynamic form

[SmarterJB]

Q	A
Bug fix?	[x]
New feature?	[ ]
New sample?	[ ]
Related issues?	fixes #1315

What's in this Pull Request?

I changed the way the DynamicForm component fetches the initial data from user fields. I changed it to use the UPN instead of the ID, because as described in issue #1315, this leads to problems when "People and Groups" are enabled in the SharePoint field.

I had to also remove the parsing of the user IDs from the defaultValues, because there are no longer the IDs there.

[SmarterJB]

@joelfmrodrigues maybe someone can look into this? we have a problem with that at a project from us, and this would really help a lot! :) thanks in advance!

[joelfmrodrigues]

@SmarterJB sorry that it took so long to find the time to review this.
I tested your code and everything seems to work well, except for editing an items with a user field containing a group.
Test list:

List item number 1 works fine, and the edit form displays the title and user (Adele) correctly by default.
I then tried with item number 2, and only the title is pre-populated. The group is not loaded.

I then switched back to the dev branch to double-check if this was a gap in your version compared to the current behaviour, and actually got the exact same result. The user is pre-loaded, but not the group.

Can you confirm if these were also the results that you experienced?

This was the part of your comment that made me double-check things:
"I had to also remove the parsing of the user IDs from the defaultValues, because there are no longer the IDs there"
Did we lose any functionality with your changes? (just to ensure I didn't miss something here)

[SmarterJB]

Damn @joelfmrodrigues you are right, groups are not loaded correctly, because my select on fieldname/Name for users returns their UPN, but for Groups it just returns the groupname!

const apiUrl = `${webAbsoluteUrl}/_api/web/lists(@listId)/items(${listItemId})?@listId=guid'${encodeURIComponent(listId)}'&$select=${fieldName}/Title,${fieldName}/Id,${fieldName}/Name&$expand=${fieldName}`;

Will look into this and get you a solution asap!

[SmarterJB]

Hey @joelfmrodrigues! I figured it out, it was a problem we had in the code before, because in single user fields there was a request to the sharepoint rest API with /_api/web/getuserbyid(${userId}) which cannot work with a group as this will always yield a not found exception from the server!

I changed it now so that the value from the single field gets fetched the same way as the values from the multiuser field!

[SmarterJB]

But I have no clue why the check failed now!

[joelfmrodrigues]

@SmarterJB Many thanks for the super quick update.
I have tested it using the same list but unfortunately, now the form never loads, for both user or group.
My list field is configured as a single value.

Went on debug and the issue seems to be in the foreach loop to parse the response items here:

The response I received was not an array:

And the following exception was captured

Could you please have a look?

[SmarterJB]

Hey @joelfmrodrigues!
My bad! I converted a multiuser field to a singleuser field, thats why it still worked on my test!

I rewrote the single user method from before now it should work!

[joelfmrodrigues]

@SmarterJB many thanks! This is now merged and should be available on the beta release in a few minutes.