Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for hidden fields in DynamicForm control #1307

Merged
merged 7 commits into from
Sep 17, 2022

Conversation

PaoloPia
Copy link
Contributor

@PaoloPia PaoloPia commented Sep 8, 2022

Q A
Bug fix? [ ]
New feature? [X ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

I simply added the capability to hide some of the fields while rendering the DynamicForm control.
I also added an item to the changelog. Please, feel free to update it accordingly to your release plans.
Thanks.

@joelfmrodrigues joelfmrodrigues changed the base branch from master to dev September 8, 2022 15:44
@joelfmrodrigues
Copy link
Collaborator

Hey @PaoloPia , I have updated the PR to target the dev branch and there is a conflict with the changelog file as in dev we already had an entry for 3.11.0. Can you please resolve conflicts, or if it's easier, just remove the file from PR and we can update the changelog after.

@PaoloPia
Copy link
Contributor Author

PaoloPia commented Sep 8, 2022

Hi @joelfmrodrigues, Thanks for such a prompt response. Sure I just updated the PR. Sorry for targeting master instead of dev :-) ...

@AJIXuMuK AJIXuMuK merged commit e0e16c8 into pnp:dev Sep 17, 2022
@AJIXuMuK
Copy link
Collaborator

Thanks @PaoloPia!

@SmarterJB
Copy link
Contributor

Hey guys, it seems to me that there is no check if the hiddenfields property is undefined or not! I created a PR which fixes it #1314

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants