Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Assets Issue in FilePicker - Your organization tab is not shown #596

Closed
rabwill opened this issue Jul 1, 2020 · 4 comments
Closed
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@rabwill
Copy link

rabwill commented Jul 1, 2020

Category

[ ] Enhancement

[x ] Bug

[ ] Question

Version

1.19.0

Expected / Desired Behavior / Question

Your organisation tab shown to get images/files provided by your organization, where filepicker has not provided props to hide

Observed Behavior

Your organization is not displayed and when you debug there are issues in the code which makes the org tab not visible

Steps to Reproduce

  • Your org assets are in the root site collection
  • Add FilePicker controls
  • No Your organization

Further if this helps:

The issues are in the files

FilePicker.tsx

Line 58
The condition should be (instead of && operation || should be used and sometimes we are not passing this prop and will be undefined)
if (this.props.hideOrganisationalAssetTab != undefined || !this.props.hideOrganisationalAssetTab ) {

FileBrowserService.ts

Line 268
Function buildAbsoluteUrl , need to have "/" if Library url does not start with a "/"

OrgAssetsService.ts

Line 76
Null check for function _parseOrgAssetsLibraryItem 's
libItem.ThumbnailUrl

It will be best to do null check for any property of the object, not only the item we need.

Hope that helps.
I can also take it up, if my approach of the fix sounds reasonable.

Thanks,
Rabia

Thanks!

@ghost
Copy link

ghost commented Jul 1, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jul 1, 2020
@Timhaka
Copy link

Timhaka commented Aug 24, 2020

Any news regarding this issue?

AJIXuMuK added a commit that referenced this issue Aug 27, 2020
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Aug 27, 2020
@AJIXuMuK AJIXuMuK added this to the 1.20.0 milestone Aug 27, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @rabwill!
Thanks for reporting that and providing steps for fix!

The fix will be available in the next release.
In a meanwhile you can test it in beta version.

BTW, I've added you Rabia as a contributor as you provided the solution! Thank you!

@rabwill
Copy link
Author

rabwill commented Aug 27, 2020

Wohoo!! Thanks so much @AJIXuMuK ! You are awesome 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

3 participants