Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic form loading error in other site #1758

Closed
IRRDC opened this issue Feb 7, 2024 · 5 comments · Fixed by #1761 or #1816
Closed

Dynamic form loading error in other site #1758

IRRDC opened this issue Feb 7, 2024 · 5 comments · Fixed by #1761 or #1816
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@IRRDC
Copy link
Contributor

IRRDC commented Feb 7, 2024

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.17.0]

Expected / Desired Behavior / Question

After updating to 3.17.0: When displaying the dynamic form for a list or library in a different site using webAsboluteUrl the form doesn't load but displays the error "An error occurred while loading: Cannot read properties of undefined (reading 'filter')" instead.

@ghost
Copy link

ghost commented Feb 7, 2024

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Feb 7, 2024
IRRDC added a commit to IRRDC/sp-dev-fx-controls-react that referenced this issue Feb 8, 2024
Added missing references to webURL to service calls.
@IRRDC
Copy link
Contributor Author

IRRDC commented Feb 8, 2024

I found the problem and created a fix for it 45050da but I guess I have to do another fork or undo my previous fixes changes to create a separate PR.

@joelfmrodrigues
Copy link
Collaborator

Hi @IRRDC , would a new branch not work in this case? I assume you are already working on a fork of the original repo so a new branch should be fine. Or am I missing something?

IRRDC added a commit to IRRDC/sp-dev-fx-controls-react that referenced this issue Feb 8, 2024
Added missing references to webURL to service calls.
@IRRDC IRRDC mentioned this issue Feb 8, 2024
@michaelmaillot michaelmaillot added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. type:bug and removed Needs: Triage 🔍 labels Feb 8, 2024
@IRRDC
Copy link
Contributor Author

IRRDC commented Feb 16, 2024

Could this fix be released as a minor version since the problem blocks all use of the dynamic form in scenarios that span sites?

@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Mar 4, 2024
@joelfmrodrigues
Copy link
Collaborator

@IRRDC your fix has been merged, thanks! But I am unable to confirm a release date at the moment. Hoping we can get some time for a release soon.

@joelfmrodrigues joelfmrodrigues added this to the 3.18.0 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants