Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker: Option "From a Link". Cannot enter a link manually #1101

Open
ghost opened this issue Jan 27, 2022 · 5 comments
Open

FilePicker: Option "From a Link". Cannot enter a link manually #1101

ghost opened this issue Jan 27, 2022 · 5 comments

Comments

@ghost
Copy link

ghost commented Jan 27, 2022

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.5.0]

Expected / Desired Behavior / Question

When disabling property "hideLinkUploadTab" a Tab "From a link is shown". If i try to enter a link manually, it will not work, copy & paste link works. It seems taht the textbox is disbaled for editing. Maybe there is a reason for this?

Our users would like to enter links manually.

Observed Behavior

Users can enter links manually in Tab "From a link".

Steps to Reproduce

Use File Picker with Option hideLinkUploadTab set to false and try to add a link manually (by adding text with my keyboard ;-))

Thanks!

@ghost
Copy link

ghost commented Jan 27, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Jan 27, 2022
@kpfeuffer
Copy link

Any updates on this? It doesnt seem to have changed in 3.6.0

@kenneth-man
Copy link

kenneth-man commented Sep 1, 2022

A solution is to use the 'renderCustomLinkTabContent' prop to render a custom input, and hide the default input

<FilePicker
	...other props...					
	renderCustomLinkTabContent={
		(filePickerResult: IFilePickerResult): JSX.Element | null => <CustomInput />
	}
/>

@murchelon
Copy link

Same with me here. I saw the above answer, where kenneth sugests to use a custom input and hide the default input. But, i think that the only way of doing that is accessing the DOM and manually disable the default input.
In other words, the default input is aways there

@Ateina
Copy link
Contributor

Ateina commented May 4, 2024

Hi @michaelmaillot @joelfmrodrigues!
I want to contribute to this issue. Could you please assign it me?

Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue May 4, 2024
Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue May 4, 2024
…"From a link" tab"

This reverts commit e2afed6.

Revert "pnp#1101: fix issue with adding link by typing in FilePicker "From a link" tab"

This reverts commit e2afed6.
Ateina added a commit to Ateina/sp-dev-fx-controls-react that referenced this issue May 4, 2024
joaojmendes added a commit that referenced this issue May 19, 2024
…k-manually

#1101: Fix issue with adding link by typing in FilePicker "From a link" tab
michaelmaillot pushed a commit that referenced this issue Aug 10, 2024
* #1135: fix keys for ordered list

* #1101: fix issue with adding link by typing in FilePicker "From a link" tab

* Revert "#1101: fix issue with adding link by typing in FilePicker "From a link" tab"

This reverts commit e2afed6.

Revert "#1101: fix issue with adding link by typing in FilePicker "From a link" tab"

This reverts commit e2afed6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants