Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Fix Add-PnPFile throwing "Access Denied" error with existing folders with Read permission at Web level #2478

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions Commands/Files/AddFile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,7 @@ protected override void ExecuteCmdlet()
}
}

SelectedWeb.EnsureProperty(w => w.ServerRelativeUrl);

var folder = SelectedWeb.EnsureFolder(SelectedWeb.RootFolder, Folder);
var folder = GetFolder();
var fileUrl = UrlUtility.Combine(folder.ServerRelativeUrl, FileName);

ContentType targetContentType = null;
Expand Down Expand Up @@ -236,5 +234,31 @@ protected override void ExecuteCmdlet()
ClientContext.ExecuteQueryRetry();
WriteObject(file);
}

private Folder GetFolder()
{
// First try to get the folder if it exists already. This avoids an Access Denied exception if the current user doesn't have Full Control access at Web level
SelectedWeb.EnsureProperty(w => w.ServerRelativeUrl);
var Url = UrlUtility.Combine(SelectedWeb.ServerRelativeUrl, Folder);

Folder folder = null;
try
{
#if ONPREMISES
folder = SelectedWeb.GetFolderByServerRelativeUrl(Url);
#else
folder = SelectedWeb.GetFolderByServerRelativePath(ResourcePath.FromDecodedUrl(Url));
#endif
folder.EnsureProperties(f => f.ServerRelativeUrl);
return folder;
}
catch (ServerException serverEx) when (serverEx.ServerErrorCode == -2147024894)
{
// If the folder doesn't exist, create it
folder = SelectedWeb.EnsureFolder(SelectedWeb.RootFolder, Folder);
folder.EnsureProperties(f => f.ServerRelativeUrl);
return folder;
}
}
}
}