Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lanczos.py to decomp.py #191

Merged
merged 5 commits into from
May 27, 2024
Merged

Rename lanczos.py to decomp.py #191

merged 5 commits into from
May 27, 2024

Conversation

pnkraemer
Copy link
Owner

Why?

  • (major) Because not all functionality in this module should be attributed to Lanczos. For example, bi-diagonalisation is due to Golub/Kahan/Li
  • (major) Because this renaming opens the door to adding other decompositions, e.g., Arnoldi (stay tuned!)
  • (minor) Because decomp.py expresses better what this module provides, instead of how this module provides what it provides.

@pnkraemer pnkraemer merged commit cb86c32 into main May 27, 2024
6 checks passed
@pnkraemer pnkraemer deleted the rename-lanczos-to-decomp branch May 27, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant