Restore STDERR in pngtest.c #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungeman
added a commit
to bungeman/freetype2-testing
that referenced
this pull request
May 2, 2024
The libpng project has moved its upstream. Also update to the newest release. Unfortunately, rolling to v1.6.63 is blocked until the tests are fixed [0]. [0] pnggroup/libpng#557
bungeman
added a commit
to bungeman/freetype2-testing
that referenced
this pull request
May 2, 2024
The libpng project has moved its upstream. Also update to the newest release. Unfortunately, rolling to v1.6.63 is blocked until the tests are fixed [0]. [0] pnggroup/libpng#557
|
This should be an issue with a repro; i.e. report a bug, don't suggest a fix. |
In "test: Add consistency checks for the PNG_LIBPNG_VER* number" [0] the `STDERR` macro was moved from outside an `ifdef` to inside an `ifdef`. This broke the code in the `else` of this `ifdef` which also uses the `STDERR` macro. Move `STDERR` back to where it was to avoid compile errors in the `else` case. [0] pnggroup@cc8006c Fixes: pnggroup#560
ctruta
approved these changes
Sep 8, 2024
|
Integrated in the main branch -- many thanks. |
bungeman
added a commit
to bungeman/freetype2-testing
that referenced
this pull request
Sep 9, 2024
The libpng project has moved its upstream. Also update to the newest release. Rolling to this commit picks up a fix for tests [0]. [0] pnggroup/libpng#557
bungeman
added a commit
to freetype/freetype2-testing
that referenced
this pull request
Sep 9, 2024
The libpng project has moved its upstream. Also update to the newest release. Rolling to this commit picks up a fix for tests [0]. [0] pnggroup/libpng#557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "test: Add consistency checks for the PNG_LIBPNG_VER* number" [0] the
STDERRmacro was moved from outside anifdefto inside anifdef. This broke the code in theelseof thisifdefwhich also uses theSTDERRmacro. MoveSTDERRback to where it was to avoid compile errors in theelsecase.[0] cc8006c
Fixes: #560