Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loongarch support and LSX SIMD optimizations #516

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

XiWeiGu
Copy link
Contributor

@XiWeiGu XiWeiGu commented Jan 8, 2024

Enable LSX by default: ./autogen.sh --maintainer && ./configure && make
Disable LSX: ./autogen.sh --maintainer && ./configure --enable-loongarch-lsx=no && make

Enable LSX by default: ./autogen.sh --maintainer && ./configure && make
Disable LSX: ./autogen.sh --maintainer && ./configure --enable-loongarch-lsx=no && make
@XiWeiGu
Copy link
Contributor Author

XiWeiGu commented Jan 8, 2024

@ctruta , Could you please take some time to review the code?

Copy link
Member

@ctruta ctruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ctruta ctruta merged commit 7885f0a into pnggroup:libpng16 Jan 17, 2024
@ctruta
Copy link
Member

ctruta commented Jan 17, 2024

Oops I almost missed one thing: that the libpng developers (not the users) are the ones who run
./autogen.sh --maintainer
I'll do this for you.

@ctruta
Copy link
Member

ctruta commented Jan 18, 2024

Done. See a7fe341.

... but now, after landing the last three commits, ./configure --enable-hardware-optimizations is broken, and we must have it fixed before we ship the next release. Could you please take a look?

While at it, could you also verify if I updated the AUTHORS file correctly?

@XiWeiGu
Copy link
Contributor Author

XiWeiGu commented Jan 18, 2024

I will address it promptly.

@ctruta
Copy link
Member

ctruta commented Jan 18, 2024

Thank you. Could you please also have a look at compilation with
gcc -Wundef
because that one is complaining as well.

@XiWeiGu
Copy link
Contributor Author

XiWeiGu commented Jan 18, 2024

Done. See a7fe341.

... but now, after landing the last three commits, ./configure --enable-hardware-optimizations is broken, and we must have it fixed before we ship the next release. Could you please take a look?

I apologize for the oversight and appreciate your reminder. The issue has been addressed in the PR #526

@XiWeiGu
Copy link
Contributor Author

XiWeiGu commented Jan 18, 2024

While at it, could you also verify if I updated the AUTHORS file correctly?

"ZhangLixia" has resigned and is no longer maintaining the Loongson ecosystem. I suggest replacing her with "JinBo," who is the primary contributor to LoongArch LSX optimizations.

@XiWeiGu
Copy link
Contributor Author

XiWeiGu commented Jan 18, 2024

Thank you. Could you please also have a look at compilation with gcc -Wundef because that one is complaining as well.

Reiterating my gratitude. PR #527 has already fixed this issue.

@ctruta
Copy link
Member

ctruta commented Jan 18, 2024

While at it, could you also verify if I updated the AUTHORS file correctly?

"ZhangLixia" has resigned and is no longer maintaining the Loongson ecosystem. I suggest replacing her with "JinBo," who is the primary contributor to LoongArch LSX optimizations.

This is very good to know, thanks. I added JinBo to the list of authors.

About ZhangLixia, I'm still keeping her name in there, because she co-authored source code such as mips/filter_mmi_inline_assembly.c, in official Loongson capacity, and that merit is not going to "expire" 🙂

And, if I may please ask for yet one more favour. The Authors file is in ASCII right now, but I want to convert it to UTF-8 eventually. Could you please send me the correct Chinese spellings for all Loongson contributors?

@jinboson
Copy link
Contributor

Could you please send me the correct Chinese spellings for all Loongson contributors?

GuXiWei --> 顾希伟
JinBo --> 金波
ZhangLixia --> 张利霞

Hope this may help. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants