feat(viem): migrate to viem #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviera9
reviewed
Sep 22, 2023
| @@ -6,8 +6,8 @@ export function isHexPrefixed(_string: string) { | |||
| return _string.slice(0, 2).toLocaleLowerCase() === HEX_PREFIX | |||
| } | |||
|
|
|||
| export function addHexPrefix(_string: string) { | |||
| return isHexPrefixed(_string) ? _string : HEX_PREFIX + _string | |||
| export function addHexPrefix(_string: string): `0x${string}` { | |||
There was a problem hiding this comment.
I don't understand this change. The function has already been tested and working.
There was a problem hiding this comment.
viem requires 0x${string} instead of string where an hash is passed.
oliviera9
reviewed
Sep 22, 2023
| import { PayableTxOptions } from 'web3-eth-contract' | ||
| import { Abi, PublicClient, WalletClient, TransactionReceipt } from 'viem' | ||
| import events from './abi/events' | ||
| // import { privateKeyToAccount } from 'viem/accounts' |
oliviera9
reviewed
Sep 22, 2023
| return this | ||
| } | ||
| } | ||
| // class SendObject<T> { |
There was a problem hiding this comment.
Can't you re-enable this? There should be a way to set gas price/limit in viem as well.
oliviera9
reviewed
Sep 22, 2023
| const accounts = await _web3.eth.getAccounts() | ||
| return accounts[0] | ||
| } | ||
| // export async function getAccount(_web3: Web3): Promise<string> { |
There was a problem hiding this comment.
No way to get the address? If not, remove the function making sure it's not used elsewhere.
oliviera9
suggested changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.