chore(rollup): clarify the callback argument 'e' to 'entry' #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Open in Stackblitz • demo • starter commit: |
dai-shi
reviewed
Jan 12, 2025
| @@ -50,7 +50,7 @@ function createESMConfig(input, output) { | |||
| output: { file: output, format: 'esm' }, | |||
| external, | |||
| plugins: [ | |||
| alias({ entries: entries.filter((e) => !e.find.test(input)) }), | |||
| alias({ entries: entries.filter((entry) => !entry.find.test(input)) }), | |||
rollup.config.mjs
Outdated
Comment on lines
94
to
100
| const argKeys = Object.keys(args) | ||
| let configKey = argKeys.find((argKey) => argKey.startsWith('config-')) | ||
|
|
||
| if (configKey) { | ||
| configKey = configKey.slice('config-'.length).replace(/_/g, '/') | ||
| } else { | ||
| c = 'index' | ||
| configKey = 'index' |
There was a problem hiding this comment.
No thanks. It doesn't feel more readable.
rollup.config.mjs
Outdated
Comment on lines
104
to
108
| ...(configKey === 'index' | ||
| ? [createDeclarationConfig(`src/${configKey}.ts`, 'dist')] | ||
| : []), | ||
| createCommonJSConfig(`src/${configKey}.ts`, `dist/${configKey}.js`), | ||
| createESMConfig(`src/${configKey}.ts`, `dist/esm/${configKey}.mjs`), |
sukvvon
force-pushed
the
chore/clarify-variables-in-rollup-config
branch
from
e0690b7 to
dfd1b0e
Compare
|
@dai-shi I reflected your opinions. |
sukvvon
changed the title
This was referenced Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
rollup.config.mjsCheck List
pnpm run fix:formatfor formatting code and docs