Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme.md): change 'npm i' to 'npm install' #2905

Merged
merged 1 commit into from
Dec 16, 2024
Merged

docs(readme.md): change 'npm i' to 'npm install' #2905

merged 1 commit into from
Dec 16, 2024

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 16, 2024 •
edited
Loading

Summary

  • Since this is an official document, I determined that using npm install instead of the abbreviation npm i is more appropriate, so I made the change in readme.md.
  • also in official docs, it is written npm install

Check List

  • pnpm run prettier for formatting code and docs

@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 0:08am

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz • demo

npm i https://pkg.pr.new/zustand@2905

commit: 3e23946

dai-shi
dai-shi approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was kind of intentional, but I don't mind merging it.

@dai-shi
Copy link
Member

dai-shi commented Dec 16, 2024

Let's have @dbritto-dev for a second opinion.

@dbritto-dev
Copy link
Collaborator

@dai-shi @sukvvon let's do it

@dbritto-dev dbritto-dev merged commit 51c00d2 into pmndrs:main Dec 16, 2024
28 checks passed
@sukvvon sukvvon deleted the docs/npm-i-to-install branch December 16, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sukvvon @dai-shi @dbritto-dev