-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update slices-pattern.md #2046
Update slices-pattern.md #2046
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4b1ce37:
|
Super, just please include typescript example as well. |
we've already a ts guide -> https://docs.pmnd.rs/zustand/guides/typescript |
Yes, I have seen that as well, just please include this StateCreator<
BearSlice & FishSlice,
[],
[],
FishSlice
> here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me, but leaving others to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Co-authored-by: Blazej Sewera <code@sewera.dev>
Co-authored-by: Blazej Sewera <code@sewera.dev>
Related Issues or Discussions
Improving docs
Summary
The current guide could misguide people in sense that they could use create slice functions to access functions but also any non function which is wrong
Check List
yarn run prettier
for formatting code and docs