Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New implementation of proxyMap and proxySet with performance improvements #965

Merged
merged 170 commits into from
Oct 16, 2024
Merged

New implementation of proxyMap and proxySet with performance improvements #965

merged 170 commits into from
Oct 16, 2024
+478 −148

Conversation

overthemike
Copy link
Collaborator

@overthemike overthemike commented Oct 13, 2024 •
edited
Loading

Related Bug Reports or Discussions

#943

Summary

Improvements:

  • performance improvements from O(n) to O(log n) for both proxyMap and proxySet

proxySet now has new Set methods:

  • intersection
  • isDisjointFrom
  • isSubsetOf
  • isSupersetOf
  • symmetricDifference
  • union

Fixed some previously unknown bugs with old implementations and added some new tests.

Check List

  • pnpm run prettier for formatting code and docs

@overthemike
pushing up to get more eyes on it
f7ab143
@overthemike
added test for snapshot
8ade601
@overthemike
taking a break
b13d580
@overthemike
taking a break
6ce93c9
@overthemike
removing extra set methods for now
5d7690e
@overthemike
sealed proxied obects
c66c4b2
@overthemike
got all tests to pass
fa2be06
@overthemike
got rid of comma
2b467bc
@overthemike
got rid of set tests in utils folder
122ca59
@overthemike
update version after update
dbfafa2
@overthemike
updated to allow values to be keys
d6a2f3a
@overthemike
updated to allow values to be keys
bf082f3
@overthemike
updated package.json scripts
1795e74
@overthemike
2.0.1
2db267c
@overthemike
changing brances so storing attempts
02da182
@overthemike
updates
e776ccf
@overthemike
fixed get
feb9578
@overthemike
added return type to fix types on snapshot
62f89d0
@overthemike
added this.data.length in has method
bdfceac
@overthemike
updated has to only show this.data.map if key doesn't exist
79fc0f1
@overthemike
updated has to only show this.data.map if key doesn't exist
1bab946
@overthemike
changed has to check if it's in a snapshot
5112f4f
@overthemike
remove getVersion - doesn't work
bdaff93
@overthemike
added back in canProxy
b79ae22
@overthemike
imported canProxy from valtio
fe6e3c0
@overthemike
removed unneeded functions and checks that are done in valtio core
472dfbb
@overthemike
changed canProxy
c140943
@overthemike
pushing up for proxyMap testing
28ea00b
@overthemike
removed unused file
5ad1f91
@overthemike
updated proxyMap to use sparse array
6e0e55b
dai-shi
dai-shi reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the final review.

src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
dai-shi
dai-shi reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do the same.

src/vanilla/utils/proxyMap.ts Outdated Show resolved Hide resolved
src/vanilla/utils/proxySet.ts Outdated Show resolved Hide resolved
@overthemike overthemike changed the title Keyed collections New implementation of proxyMap and proxySet with performance improvements Oct 16, 2024
@dai-shi dai-shi marked this pull request as ready for review October 16, 2024 01:13
dai-shi
dai-shi approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dai-shi dai-shi merged commit 131df82 into main Oct 16, 2024
29 checks passed
@dai-shi dai-shi deleted the keyed-collections branch October 16, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overthemike @dai-shi