-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pkg.pr.new #896
feat: add pkg.pr.new #896
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
it's failing now because the app must be installed. |
I'm fine to add pkg.pr.new, but please don't remove codesandbox ci yet. |
But, it says "or". |
Yea, it's a bit misleading, we'll change the error message! But anyway, it requires pkg.pr.new app. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
$ npm i https://pkg.pr.new/pmndrs/valtio/valtio@e688081
$ ls node_modules/valtio
LICENSE package.json tsconfig.json
dist/ readme.md vitest.config.ts
docs/ rollup.config.js website/
examples/ src/
logo.svg tests/ Unfortunately, it isn't built correctly. FYI: $ npm i https://pkg.csb.dev/pmndrs/valtio/commit/e6880814/valtio
$ ls node_modules/valtio
LICENSE
esm/
index.d.ts
index.js
package.json
react/
react.d.ts
react.js
readme.md
ts_version_4.5_and_above_is_required.d.ts
utils.d.ts
utils.js
vanilla/
vanilla.d.ts
vanilla.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
☝️
@dai-shi What files are missing? the / type files? |
It's too many files. We publish only With CSB: Line 2 in 057033d
|
now I guess it's publishing the dist folder |
https://github.com/pmndrs/valtio/actions/runs/9114322700/job/25057962260?pr=896 looks good. I receive this email, and am wondering where it's coming from:
This is not the first time. It seems something is wrong. |
Weird, could you send the email screenshot? maybe it's a bug from our side that submits emails as errors (I don't think so tbh, but worth a try) |
I always receive this email from GitHub notifications when a check is failed not only in this repo but, in all of the repos I open a PR in, and I think before you verify the commit, the checks go red, that's why all of the participants receive this email ( including you and Mohammad ) . |
Are you sure? I never received this email before in other repos.
So, Mohammad should receive it too. |
Weirdly enough, I didn't receive it, maybe because I'm not part of the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always receive this email from GitHub notifications when a check is failed
I received the email when the check succeeded. This problem should be addressed.
Agreed, maybe we should close this PR and re-create a new PR from the branch and see if we can reproduce the issue again! wdyt? |
You can try, but I think creating a new PR doesn't help much. We can add an empty commit to trigger workflows. Let me try one. |
Confirmed. I got the email again.
|
Thanks, is the app removed now? |
wow, it just got green? that's weird. |
As I said, this email should only be received when a check is failed ( due to my gh notif settings ) as written in the email. the reason why we are receiving this is because when we commit, the first 10-20 seconds a check fails ( which is weird, I will attach an image so you can see it ). then it gets disappeared and we go green. |
I think it's because it's not approved in those times? Could you check the details of that failed run and see what's the exact issue (a screenshot maybe)? |
Ok I guess I might know the answer, we have a webhook event that listens for the opening of PRs! And at that point, marks an event as a PR, so the following workflow run in PR mode! And what happens is because we added the app after the PR opening, it does not identify this as a PR properly. This might solve the issue! stackblitz-labs/pkg.pr.new#53 Let's close this & open a new PR from the branch. |
Oh yes.. it makes sense. lets try that. I am going to close this PR and open a new one. |
This PR adds pkg.pr.new to the repo