Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] fix: make affected per proxy #868

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[v2] fix: make affected per proxy #868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/react.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ export function useSnapshot<T extends object>(
options?: Options,
): Snapshot<T> {
const notifyInSync = options?.sync
// per-hook affected, it's not ideal but memo compatible
const affected = useMemo(() => new WeakMap<object, unknown>(), [])
// per-proxy & per-hook affected, it's not ideal but memo compatible
// eslint-disable-next-line react-hooks/exhaustive-deps
const affected = useMemo(() => new WeakMap<object, unknown>(), [proxyObject])
const lastSnapshot = useRef<Snapshot<T>>()
let inRender = true
const currSnapshot = useSyncExternalStore(
Expand Down
Loading