added isSnapshot function for better readability

pmndrs · Oct 8, 2024 · 74f0ad8 · 74f0ad8
1 parent 6fcb3cb
commit 74f0ad8
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/vanilla/utils/proxyMap.ts b/src/vanilla/utils/proxyMap.ts
@@ -2,6 +2,8 @@ import { getVersion, proxy } from '../../vanilla.ts'
 
 const maybeProxify = (x: any) => proxy({ x }).x
 
+const isSnapshot = (context: any) => getVersion(context) === undefined
+
 type InternalProxyObject<K, V> = Map<K, V> & {
   data: Array<[K, V | undefined]>
   size: number
@@ -44,14 +46,14 @@ export function proxyMap<K, V>(entries?: Iterable<[K, V]> | undefined | null) {
     },
     has(k: K) {
       const key = maybeProxify(k)
-      if (!indexMap.has(key)) {
+      if (!indexMap.has(key) && isSnapshot(this)) {
         // eslint-disable-next-line @typescript-eslint/no-unused-expressions
         this.data.length
       }
       return indexMap.has(key)
     },
     set(key: K, value: V) {
-      if (getVersion(this) === undefined) {
+      if (isSnapshot(this)) {
         if (import.meta.env?.MODE !== 'production') {
           throw new Error('Cannot perform mutations on a snapshot')
         } else {
@@ -76,7 +78,7 @@ export function proxyMap<K, V>(entries?: Iterable<[K, V]> | undefined | null) {
       return this
     },
     delete(key: K) {
-      if (getVersion(this) === undefined) {
+      if (isSnapshot(this)) {
         if (import.meta.env?.MODE !== 'production') {
           throw new Error('Cannot perform mutations on a snapshot')
         } else {
@@ -93,7 +95,7 @@ export function proxyMap<K, V>(entries?: Iterable<[K, V]> | undefined | null) {
       return false
     },
     clear() {
-      if (getVersion(this) === undefined) {
+      if (isSnapshot(this)) {
         if (import.meta.env?.MODE !== 'production') {
           throw new Error('Cannot perform mutations on a snapshot')
         } else {