correct enumerable default (#726)

pmndrs · Oct 20, 2023 · 74bfb46 · 74bfb46
1 parent bc0bf6f
commit 74bfb46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/vanilla.ts b/src/vanilla.ts
@@ -125,8 +125,8 @@ const buildProxyFunction = (
         return
       }
       const value = Reflect.get(target, key)
-      const { enumerable = true } =
-        Reflect.getOwnPropertyDescriptor(target, key) ?? {}
+      const { enumerable = false } =
+        Reflect.getOwnPropertyDescriptor(target, key) as PropertyDescriptor
       const desc: PropertyDescriptor = {
         value,
         enumerable,

diff --git a/tests/basic.test.tsx b/tests/basic.test.tsx
@@ -1,7 +1,7 @@
 import { StrictMode, useEffect, useRef, useState } from 'react'
 import { fireEvent, render, waitFor } from '@testing-library/react'
-import { proxy, useSnapshot, snapshot } from 'valtio'
 import { expect, it, vi } from 'vitest'
+import { proxy, snapshot, useSnapshot } from 'valtio'
 
 it('simple counter', async () => {
   const obj = proxy({ count: 0 })
@@ -495,6 +495,6 @@ it('sync snapshot between nested components (#460)', async () => {
 })
 
 it('respects property enumerability (#726)', async () => {
-  let x = proxy(Object.defineProperty({ a: 1 }, 'b', { value: 2 }))
+  const x = proxy(Object.defineProperty({ a: 1 }, 'b', { value: 2 }))
   expect(Object.keys(snapshot(x))).toEqual(Object.keys(x))
 })