Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Codespaces editor support #312

Closed
wants to merge 1 commit into from

Conversation

Glavin001
Copy link
Contributor

@Glavin001 Glavin001 commented Dec 17, 2021

https://github.com/features/codespaces

How to test

Prerequisite

Have access to GitHub Codespaces: https://github.com/features/codespaces

Codespaces is rolling out progressively on August 11th, 2021 and can be enabled in settings by organization owners for Team and Enterprise Cloud plans. For users in individual plans, we’re extending the existing Codespaces beta. For those in the beta, access will remain and we’ll share updates on what’s coming in the near future.

  1. If you do have it then you should see a Code dropdown button:

image

  1. Then click New Codespaces:

image

@vercel
Copy link

vercel bot commented Dec 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/use-cannon/ARDymXzcYuzBKzJyuznTMh2gHMXK
✅ Preview: https://use-cannon-git-fork-glavin001-feat-github-codespaces-pmndrs.vercel.app

@bjornstar
Copy link
Member

Looks neat, how do we see it in action?

@Glavin001
Copy link
Contributor Author

Glavin001 commented Dec 18, 2021

@bjornstar : Added how to instructions to PR description. Requires GitHub Codespaces access which is not available for all.

Most importantly is ensuring this does not break existing local development or CI, which I don't expect it will.

A fresh Codespace with this config works for me to edit examples with Vite, while I could not before. Hopefully someone else can test, too.

@bjornstar
Copy link
Member

This seems like a great idea, but I am concerned about the pricing model in particular. It looks like as a member of an organization poimandres would be on the hook for paying the bill for our usage of this feature even though our projects are all free and open source.

Without codespaces being available to everyon and with the current pricing structure it's hard to see the value it brings to the project.

I will be happy to bump the version of vite to enable this, but I don't think codespaces specific code belongs in the project at this point in time.

@Glavin001
Copy link
Contributor Author

I don't think codespaces specific code belongs in the project at this point in time.

Agreed. Ideally this is implemented in Vite itself. I may submit a PR over in Vite later. At least for now I am unblocked and can contribute to use-cannon 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants