Batch updates with rafz #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple components are using react-use-measure and a scroll event occurs, multiple react updates are executed serially.
I've got 9 components on screen which use react-use-measure, so a scroll event takes about
~2*9 =18msto finish rendering. Shown below is 3 of the updates.I use
rafzfor similar problems already (thank you by the way!), so this seemed like an elegant solution. It reduces the render time for my 9 components to~9msI don't think this substantially changes the API for those not using
rafzso I would hope it's not a breaking change? For those using it, they can opt in to batch their renders.Thanks!