feat(native): implement native EventTarget methods #3252
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 46d81ce:
|
packages/fiber/src/native/Canvas.tsx
Outdated
| <View {...props} ref={viewRef} onLayout={onLayout} style={{ flex: 1, ...style }} {...bind}> | ||
| <View {...props} ref={viewRef} onLayout={onLayout} style={{ flex: 1, ...style }}> |
There was a problem hiding this comment.
This should allow props to be spread from libraries like https://github.com/TiagoCavalcante/r3f-native-orbitcontrols which also use responder props.
|
What is the state of this PR? |
|
I need to test this and see how far off we are from supporting controls from three/examples, or libraries like pmndrs/use-gesture which are a bit more elaborate with usage. This was put on the backburner as we had some core issues with our events model for XR, which may be relevant for multi-touch or general correctness. We found an elegant way to continue which we'll implement later, so this doesn't need to be blocked. This PR just needs to support controls and the previous suspects that made canvas event props not work as they should. We may be able to backport the latter alongside #3315 if this takes too long. |
|
Waiting for this update as well. |
|
I'm back from SIGGRAPH and work this week, so I'll be continuing here. I think for responder props to work on the canvas, |
|
@CodyJasonBennett, Hey there seems to be no typings in the latest release. Declarations folder is not present for v18.17.1 inside node_modules when i checked. |
|
Fixed. #3331. |
Resolves #3173