-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): add loadAsync to Loader interface #2742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `loadAsync` method on `THREE.Loader` was removed in three-types/three-ts-types#311, since there's no consistent type definition for it. This fixes the situation by adding the `loadAsync` method here.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 10c418b:
|
renovate bot
referenced
this pull request
in ziyadedher/ziyadedher
Feb 5, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) | [`8.10.1` -> `8.10.4`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.10.1/8.10.4) | [![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/compatibility-slim/8.10.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/confidence-slim/8.10.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.10.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.10.4) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.10.3...v8.10.4) #### What's Changed - fix: transpile class properties for wider browser support by [@​belgattitude](https://togithub.com/belgattitude) in [https://github.com/pmndrs/react-three-fiber/pull/2749](https://togithub.com/pmndrs/react-three-fiber/pull/2749) **Full Changelog**: pmndrs/react-three-fiber@v8.10.3...v8.10.4 ### [`v8.10.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.10.3) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/fiber@8.10.2...v8.10.3) ##### What's Changed - fix(types): add loadAsync to Loader interface by [@​Methuselah96](https://togithub.com/Methuselah96) in [https://github.com/pmndrs/react-three-fiber/pull/2742](https://togithub.com/pmndrs/react-three-fiber/pull/2742) - fix: refactor ErrorBoundary to not use public class fields by [@​belgattitude](https://togithub.com/belgattitude) in [https://github.com/pmndrs/react-three-fiber/pull/2748](https://togithub.com/pmndrs/react-three-fiber/pull/2748) ##### New Contributors - [@​belgattitude](https://togithub.com/belgattitude) made their first contribution in [https://github.com/pmndrs/react-three-fiber/pull/2748](https://togithub.com/pmndrs/react-three-fiber/pull/2748) **Full Changelog**: pmndrs/react-three-fiber@v8.10.1...v8.10.3 ### [`v8.10.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.10.2) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/fiber@8.10.1...@react-three/fiber@8.10.2) #### What's Changed - fix: portal injects by [@​drcmda](https://togithub.com/drcmda) in pmndrs/react-three-fiber@0c288ba - fix(RTTR): backport traverse, update fixes by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [#​2736](https://togithub.com/pmndrs/react-three-fiber/issues/2736) **Full Changelog**: pmndrs/react-three-fiber@v8.10.1...v8.10.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuNSIsInVwZGF0ZWRJblZlciI6IjM0LjEyMi4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
CodyJasonBennett
added a commit
that referenced
this pull request
Feb 27, 2023
ziyadedher
referenced
this pull request
in ziyadedher/ziyadedher
Dec 16, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@react-three/fiber](https://togithub.com/pmndrs/react-three-fiber) | [`8.10.1` -> `8.10.4`](https://renovatebot.com/diffs/npm/@react-three%2ffiber/8.10.1/8.10.4) | [![age](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/compatibility-slim/8.10.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@react-three%2ffiber/8.10.4/confidence-slim/8.10.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/react-three-fiber</summary> ### [`v8.10.4`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.10.4) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/v8.10.3...v8.10.4) #### What's Changed - fix: transpile class properties for wider browser support by [@​belgattitude](https://togithub.com/belgattitude) in [https://github.com/pmndrs/react-three-fiber/pull/2749](https://togithub.com/pmndrs/react-three-fiber/pull/2749) **Full Changelog**: pmndrs/react-three-fiber@v8.10.3...v8.10.4 ### [`v8.10.3`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.10.3) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/fiber@8.10.2...v8.10.3) ##### What's Changed - fix(types): add loadAsync to Loader interface by [@​Methuselah96](https://togithub.com/Methuselah96) in [https://github.com/pmndrs/react-three-fiber/pull/2742](https://togithub.com/pmndrs/react-three-fiber/pull/2742) - fix: refactor ErrorBoundary to not use public class fields by [@​belgattitude](https://togithub.com/belgattitude) in [https://github.com/pmndrs/react-three-fiber/pull/2748](https://togithub.com/pmndrs/react-three-fiber/pull/2748) ##### New Contributors - [@​belgattitude](https://togithub.com/belgattitude) made their first contribution in [https://github.com/pmndrs/react-three-fiber/pull/2748](https://togithub.com/pmndrs/react-three-fiber/pull/2748) **Full Changelog**: pmndrs/react-three-fiber@v8.10.1...v8.10.3 ### [`v8.10.2`](https://togithub.com/pmndrs/react-three-fiber/releases/tag/v8.10.2) [Compare Source](https://togithub.com/pmndrs/react-three-fiber/compare/@react-three/fiber@8.10.1...@react-three/fiber@8.10.2) #### What's Changed - fix: portal injects by [@​drcmda](https://togithub.com/drcmda) in pmndrs/react-three-fiber@0c288ba - fix(RTTR): backport traverse, update fixes by [@​CodyJasonBennett](https://togithub.com/CodyJasonBennett) in [#​2736](https://togithub.com/pmndrs/react-three-fiber/issues/2736) **Full Changelog**: pmndrs/react-three-fiber@v8.10.1...v8.10.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/ziyadedher/ziyadedher). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuNSIsInVwZGF0ZWRJblZlciI6IjM0LjEyMi4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
itsdouges
pushed a commit
to itsdouges/react-three-fiber
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use
@types/three@0.149.0
with R3F, I get these type errors:This is caused by the
loadAsync
method being removed fromTHREE.Loader
in three-types/three-ts-types#311, since there's not a good consistent type definition for it.This fixes the situation by adding the
loadAsync
method here.This change change should be backwards-compatible, I tested it with both
@types/three@0.149.0
and@types/three@0.139.0
.