fix: WebGLMultipleRenderTargets is removed in r172. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th WebGLRenderTarget. Without it the library is not working modified: src/effects/SSR/screen-space-reflections.js
codergigachad
changed the title
Comment on lines
681
to
680
| this.gBuffersRenderTarget = new WebGLMultipleRenderTargets(width, height, 2, { | ||
| this.gBuffersRenderTarget = new WebGLRenderTarget(width, height, 2, { |
There was a problem hiding this comment.
This should be new WebGLRenderTarget(width, height, { count: 2, ... }).
There was a problem hiding this comment.
should update threejs to at least 162 to use it :/
There was a problem hiding this comment.
Yes, we have to shim or polyfill the class here depending on the installed three version. I'll do this myself since it's a bit of a hack.
|
it in the file src/effects/N8AO/N8AOPostPass.js too. line 193 |
|
🎉 This PR is included in version 2.16.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced it with WebGLRenderTarget. The library is not working without this change in the latest version of three. Moreover I haven't thoroughly tested this change. This seems to work initially. The removal also says to use the count parameter to use MTR, which I don't have enough knowledge of.