Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename store to scope container #648

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Aug 11, 2021

This is just a refactoring to rename Store to ScopeContainer and so on.

@dai-shi dai-shi requested a review from Thisen August 11, 2021 14:59
@vercel
Copy link

vercel bot commented Aug 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/7h9PGkTUpK5qCG6CStZjadQ591zx
✅ Preview: https://jotai-git-refactor-corecontext-value-name-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8dc949:

Sandbox Source
React Configuration
React Typescript Configuration

Copy link
Collaborator

@Thisen Thisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dai-shi dai-shi merged commit 94a2a18 into main Aug 12, 2021
@dai-shi dai-shi deleted the refactor/core/context-value-name branch August 12, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants