-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples, tests): remove React.FC
from the TSX file
#603
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pmndrs/jotai/82uWhK8A2z65PeeAmTwMhVrL5CmH |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a0b9f08:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for you work.
Although this might be controversial if we ask someone, but let's assume it's the trend/recommendation and merge this.
Thank you for your indulgence. I’ll continue to follow up on the issue of adding only one line between absolute path import and relative path import. |
@liby Would you mind if I ask another chore? For consistency, we'd want to use |
@dai-shi |
@dai-shi Hi, I have a question that has been bothering me for a long time and I don't have any clue, so I would like to seek help from you. The use of Rename the Changing The problem is solved, but I am still confused as to why the behavior is inconsistent when You built this project, maybe you can give me an answer? I've been obsessed with it all day. Looking forward to your reply |
...unfortunately, I don't know. I usually type imports before writing code... |
It's done.