Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): atomWithObservable type #597

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 16, 2021

There was a tiny mistake in types. (Should we add expectType in tests?)

@vercel
Copy link

vercel bot commented Jul 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/43kCybYkVfVaYLZ8LyauC4sLEHYq
✅ Preview: https://jotai-git-fix-utilsatom-with-observable-type-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d868826:

Sandbox Source
React Configuration
React Typescript Configuration

@dai-shi dai-shi merged commit dffdd25 into master Jul 16, 2021
@dai-shi dai-shi deleted the fix/utils/atom-with-observable-type branch July 16, 2021 13:58
@dai-shi dai-shi changed the title fix: atomWithObservable type fix(utils): atomWithObservable type Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant