Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(query): remove optional equalityFn from atomWith(Infinite)Query #592

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jul 14, 2021

This is basically a commit reverting #386.

#589 (comment) shows an alternative method, so I think this is not necessary.

@dai-shi dai-shi requested a review from aulneau July 14, 2021 23:58
@vercel
Copy link

vercel bot commented Jul 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/AN3eFo7fVHf1Dge3uNjH24EY1xCE
✅ Preview: https://jotai-git-breaking-queryremove-equality-fn-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7fee75d:

Sandbox Source
React Configuration
React Typescript Configuration

Copy link
Collaborator

@aulneau aulneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this makes sense :) sorry for the original change lol

@dai-shi dai-shi merged commit 868f120 into master Jul 15, 2021
@dai-shi dai-shi deleted the breaking/query/remove-equality-fn branch July 15, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants