Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): handle error in atomWithQuery #567

Merged
merged 7 commits into from
Jun 28, 2021
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jun 27, 2021

https://twitter.com/TkDodo/status/1409097749077823494

Well, it's not yet implemented yet. Now, this provides a good reproduction, let's do it.

@dai-shi dai-shi requested a review from aulneau June 27, 2021 11:18
@vercel
Copy link

vercel bot commented Jun 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/58ow63xQbGDonaLs6qKTt86BMUGm
✅ Preview: https://jotai-git-fix-queryhandle-error-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 27, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1f1b5e:

Sandbox Source
React Configuration
React Typescript Configuration

@dai-shi dai-shi changed the title fix(query): handle error fix(query): handle error in atomWithQuery Jun 27, 2021
@dai-shi
Copy link
Member Author

dai-shi commented Jun 27, 2021

Hmm, my initial trial doesn't seem to work: https://codesandbox.io/s/jotai-query-demo-forked-w9r68?file=/src/App.tsx

@aulneau Can you help?

@dai-shi
Copy link
Member Author

dai-shi commented Jun 27, 2021

https://codesandbox.io/s/jotai-query-demo-forked-ynx7m?file=/src/App.tsx
OK, finally it works as expected for me.

@dai-shi dai-shi merged commit 5844f7d into master Jun 28, 2021
@dai-shi dai-shi deleted the fix/query/handle-error branch June 28, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants