fix(utils/atomWithDefault): support refresh

[dai-shi]

close #521

• impl
• tests
• docs https://github.com/pmndrs/website/pull/108

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/GmDD8vP5v6e4Rk463xZbqxctvkhX
✅ Preview: https://jotai-git-fix-issue-521-pmndrs.vercel.app

[dai-shi]

@fkocovski Would you try this? (you can npm/yarn install the codesandbox build.)

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da1199a:

Sandbox	Source
React	Configuration
React Typescript	Configuration

[LucaColonnello]

@dai-shi I tested this with different scenarios here.

Tested the following:

• dependency tracking refreshing default value (every time you click the Change Id button, which changes a dependency)
• default value (async in this case)
• set override value (done in the useEffect)
• refresh the default value, removing the override (which calls again the getDefault function)

It seems to work perfectly fine for me in all these scenario

[dai-shi]

@LucaColonnello

Great to hear! and the csb example looks good too.
Would you be willing to contribute to this PR? There are two remaining tasks.

[LucaColonnello]

Hey @dai-shi,
I'd love to yeah!

I just need to familiarise myself with the testing setup here.

I'll look around and give it a try.

Is there a discord or slack channel (or equivalent) I can join if I get stuck where I can ask for help? (I can just write here otherwise)

[dai-shi]

Is there a discord

Yes, please find an invitation link in readme.
There's #jotai channel in the Poimandres discord server. You can DM me too.

[LucaColonnello]

Amazing thank you!

I'll let you know how it goes, I think I have an idea based on the existing atomWithDefault tests I've seen.

[LucaColonnello]

About the above failing test, I wasn't sure it was an environment issue (my local machine), but the waitForAll tests seem to be intermittently failing, and it seems unrelated to the changes on atomWithDefault.

[dai-shi]

the waitForAll tests seem to be intermittently failing

Yeah, I've seen this a few times. @Thisen can you investigate it? (but the reproduction is gone...)

[dai-shi]

Thanks to @LucaColonnello , this is ready for review and merge. Anyone, feel free to leave some comments.

[dai-shi]

the waitForAll tests seem to be intermittently failing

Yeah, I've seen this a few times. @Thisen can you investigate it? (but the reproduction is gone...)

Okay, this is probably my bad. I commented out jest.useFakeTimers().
@Thisen Will you still help me? How can we comment this in?

[Thisen]

Should be fixed now.