Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): atom type inference in hooks #1866

Merged
merged 5 commits into from
Apr 6, 2023
+28 −14
Merged

fix(react): atom type inference in hooks #1866

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aab9238
Remove conflicting type
Thisen Apr 4, 2023
3b5f92d
Change unknown to any for inference types
Thisen Apr 5, 2023
e901187
Change unknown to any for inference types for useAtomValue and useSet…
Thisen Apr 5, 2023
09cc008
Add test
Thisen Apr 5, 2023
ff27059
Fix test
Thisen Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove conflicting type
@Thisen
Thisen committed Apr 4, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit aab92387e01af0e9c5eaef82c85ae924f9b3a03b
5 changes: 0 additions & 5 deletions src/react/useAtom.ts
View file
Original file line number Diff line number Diff line change
@@ -32,11 +32,6 @@ export function useAtom<
SetAtom<ExtractAtomArgs<AtomType>, ExtractAtomResult<AtomType>>
]

export function useAtom<AtomType extends Atom<unknown>>(
atom: AtomType,
options?: Options
): [Awaited<ExtractAtomValue<AtomType>>, never]

export function useAtom<Value, Args extends unknown[], Result>(
atom: Atom<Value> | WritableAtom<Value, Args, Result>,
options?: Options