Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vanilla): reading async atom twice before resolving (v2 API) #1670

Merged
merged 8 commits into from
Jan 10, 2023

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Jan 5, 2023

close #1668.

@vercel
Copy link

vercel bot commented Jan 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 0:23AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 03829ae:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Size Change: +404 B (0%)

Total Size: 208 kB

Filename Size Change
dist/esm/vanilla.js 2.92 kB +82 B (+3%)
dist/system/vanilla.development.js 3.01 kB +85 B (+3%)
dist/system/vanilla.production.js 1.66 kB +42 B (+3%)
dist/umd/vanilla.development.js 3.92 kB +77 B (+2%)
dist/umd/vanilla.production.js 1.82 kB +41 B (+2%)
dist/vanilla.js 3.83 kB +77 B (+2%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 876 B
dist/babel/plugin-react-refresh.js 1.11 kB
dist/babel/preset.js 1.35 kB
dist/devtools.js 3.79 kB
dist/esm/babel/plugin-debug-label.js 869 B
dist/esm/babel/plugin-react-refresh.js 1.05 kB
dist/esm/babel/preset.js 1.32 kB
dist/esm/devtools.js 2.97 kB
dist/esm/immer.js 200 B
dist/esm/index.js 5.2 kB
dist/esm/optics.js 164 B
dist/esm/query.js 485 B
dist/esm/react.js 965 B
dist/esm/react/devtools.js 2.47 kB
dist/esm/react/utils.js 535 B
dist/esm/redux.js 168 B
dist/esm/urql.js 793 B
dist/esm/utils.js 5.34 kB
dist/esm/valtio.js 169 B
dist/esm/vanilla/utils.js 4.09 kB
dist/esm/xstate.js 183 B
dist/esm/zustand.js 172 B
dist/immer.js 453 B
dist/index.js 6.14 kB
dist/optics.js 404 B
dist/query.js 737 B
dist/react.js 1.06 kB
dist/react/devtools.js 3.24 kB
dist/react/utils.js 1.23 kB
dist/redux.js 409 B
dist/system/babel/plugin-debug-label.development.js 970 B
dist/system/babel/plugin-debug-label.production.js 728 B
dist/system/babel/plugin-react-refresh.development.js 1.15 kB
dist/system/babel/plugin-react-refresh.production.js 899 B
dist/system/babel/preset.development.js 1.42 kB
dist/system/babel/preset.production.js 1.1 kB
dist/system/devtools.development.js 3.16 kB
dist/system/devtools.production.js 2.11 kB
dist/system/immer.development.js 286 B
dist/system/immer.production.js 213 B
dist/system/index.development.js 5.43 kB
dist/system/index.production.js 3.02 kB
dist/system/optics.development.js 251 B
dist/system/optics.production.js 189 B
dist/system/query.development.js 609 B
dist/system/query.production.js 423 B
dist/system/react.development.js 1.13 kB
dist/system/react.production.js 714 B
dist/system/react/devtools.development.js 2.64 kB
dist/system/react/devtools.production.js 1.83 kB
dist/system/react/utils.development.js 677 B
dist/system/react/utils.production.js 424 B
dist/system/redux.development.js 255 B
dist/system/redux.production.js 192 B
dist/system/urql.development.js 938 B
dist/system/urql.production.js 625 B
dist/system/utils.development.js 5.74 kB
dist/system/utils.production.js 3.61 kB
dist/system/valtio.development.js 256 B
dist/system/valtio.production.js 193 B
dist/system/vanilla/utils.development.js 4.33 kB
dist/system/vanilla/utils.production.js 2.69 kB
dist/system/xstate.development.js 273 B
dist/system/xstate.production.js 210 B
dist/system/zustand.development.js 258 B
dist/system/zustand.production.js 194 B
dist/umd/babel/plugin-debug-label.development.js 1.04 kB
dist/umd/babel/plugin-debug-label.production.js 819 B
dist/umd/babel/plugin-react-refresh.development.js 1.26 kB
dist/umd/babel/plugin-react-refresh.production.js 985 B
dist/umd/babel/preset.development.js 1.49 kB
dist/umd/babel/preset.production.js 1.21 kB
dist/umd/devtools.development.js 3.92 kB
dist/umd/devtools.production.js 2.6 kB
dist/umd/immer.development.js 594 B
dist/umd/immer.production.js 437 B
dist/umd/index.development.js 6.25 kB
dist/umd/index.production.js 3.48 kB
dist/umd/optics.development.js 544 B
dist/umd/optics.production.js 408 B
dist/umd/query.development.js 881 B
dist/umd/query.production.js 624 B
dist/umd/react.development.js 1.19 kB
dist/umd/react.production.js 805 B
dist/umd/react/devtools.development.js 3.37 kB
dist/umd/react/devtools.production.js 2.37 kB
dist/umd/react/utils.development.js 1.39 kB
dist/umd/react/utils.production.js 1 kB
dist/umd/redux.development.js 548 B
dist/umd/redux.production.js 413 B
dist/umd/urql.development.js 4.66 kB
dist/umd/urql.production.js 3.25 kB
dist/umd/utils.development.js 10.2 kB
dist/umd/utils.production.js 6.54 kB
dist/umd/valtio.development.js 549 B
dist/umd/valtio.production.js 413 B
dist/umd/vanilla/utils.development.js 5.07 kB
dist/umd/vanilla/utils.production.js 3.14 kB
dist/umd/xstate.development.js 579 B
dist/umd/xstate.production.js 436 B
dist/umd/zustand.development.js 550 B
dist/umd/zustand.production.js 413 B
dist/urql.js 4.48 kB
dist/utils.js 9.91 kB
dist/valtio.js 408 B
dist/vanilla/utils.js 4.91 kB
dist/xstate.js 442 B
dist/zustand.js 411 B

compressed-size-action

@dai-shi dai-shi marked this pull request as ready for review January 6, 2023 12:31
@dai-shi dai-shi added this to the v1.13.0 milestone Jan 10, 2023
@dai-shi dai-shi merged commit eee9769 into main Jan 10, 2023
@dai-shi dai-shi deleted the fix/issue-1668 branch January 10, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(v2 API) Async atom with dep change won't be resolved in strict mode
1 participant