Skip to content

Commit

Permalink
PLAYWRIGHT_BROWSERS_PATH
Browse files Browse the repository at this point in the history
  • Loading branch information
abernier committed Aug 3, 2024
1 parent 4ba9481 commit 0572ed6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 7 deletions.
5 changes: 1 addition & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ jobs:
cancel-in-progress: ${{ github.event_name != 'pull_request' }}

container:
image: ghcr.io/pmndrs/playwright:main
credentials:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
image: mcr.microsoft.com/playwright:v1.45.3-jammy

steps:
#
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,12 +73,12 @@ $ BASE_PATH=/examples npm test

## Docker

For generating reproductible snapshots, we use [`ghcr.io/pmndrs/playwright:main`](https://github.com/pmndrs/playwright/pkgs/container/playwright/249720592?tag=main) Docker image.
For generating reproductible snapshots, we use [`mcr.microsoft.com/playwright:v1.45.3-jammy`](https://playwright.dev/docs/docker#image-tags) Docker image.

```sh
$ docker run -it --rm \
-w /app -v "$(pwd)":/app -v /app/node_modules \
ghcr.io/pmndrs/playwright:main /bin/sh
mcr.microsoft.com/playwright:v1.45.3-jammy /bin/sh
#
# echo "Hey, I am acting like the CI"
#
Expand All @@ -91,7 +91,7 @@ or in one command to update snapshots:
```sh
docker run --rm \
-w /app -v "$(pwd)":/app -v /app/node_modules \
ghcr.io/pmndrs/playwright:main /bin/sh -c "npm ci && npm test"
mcr.microsoft.com/playwright:v1.45.3-jammy /bin/sh -c "npm ci && npm test -- -- --update-snapshots"
```

# Colophon
Expand Down
1 change: 1 addition & 0 deletions turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"cache": true
},
"test": {
"env": ["PLAYWRIGHT_BROWSERS_PATH"],
"dependsOn": ["build2"],
"inputs": [
"$TURBO_DEFAULT$",
Expand Down

0 comments on commit 0572ed6

Please sign in to comment.