Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little silly changes ... #12

Merged
merged 4 commits into from
Jan 14, 2020
Merged

Little silly changes ... #12

merged 4 commits into from
Jan 14, 2020

Conversation

lguzzon
Copy link
Contributor

@lguzzon lguzzon commented Jan 9, 2020

No description provided.

@ahnick
Copy link
Collaborator

ahnick commented Jan 13, 2020

Hi @lguzzon. Thanks for the PR. I think these are all good changes. There are some minor adjustments that I would like you to make to the PR before we merge and I have left comments on the corresponding lines.

@lguzzon
Copy link
Contributor Author

lguzzon commented Jan 14, 2020

Hi @lguzzon. Thanks for the PR. I think these are all good changes. There are some minor adjustments that I would like you to make to the PR before we merge and I have left comments on the corresponding lines.

Thanks, but I can't find any comments on lines ... I'm wrong or what?

ahnick
ahnick reviewed Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@ahnick ahnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lguzzon. Thanks for the PR. I think these are all good changes. There are some minor adjustments that I would like you to make to the PR before we merge and I have left comments on the corresponding lines.

Thanks, but I can't find any comments on lines ... I'm wrong or what?

If you click on "Files changed" tab above here in the PR can you see my comments for encpass.sh? They should also be showing even on this conversation tab. They do not however appear in the file if you are just looking on your local machine.

@lguzzon
Copy link
Contributor Author

lguzzon commented Jan 14, 2020

Done!!!

@ahnick ahnick merged commit 90df2c4 into plyint:master Jan 14, 2020
@ahnick
Copy link
Collaborator

ahnick commented Jan 14, 2020

@lguzzon Great thanks! Merged. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnick ahnick ahnick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lguzzon @ahnick