Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 真的修了tickwarp卡了的问题么 #67

Closed
1 task done
roj234 opened this issue Feb 2, 2023 · 6 comments
Closed
1 task done

[Bug] 真的修了tickwarp卡了的问题么 #67

roj234 opened this issue Feb 2, 2023 · 6 comments
Labels
label: external issues External Issues resolution: wontfix This will not be worked on type: bug Something isn't working

Comments

@roj234
Copy link

roj234 commented Feb 2, 2023

Minecraft Version

1.19.2

MasaGadget Version

从modrinth下的3.0.1

Description

如下,然后用VisualVM追踪到了那个函数,看commit你在3.0.1有修改
Visual VM
不是说tick wrap的问题修了么,是否上传的文件的确和文件名一样是3.0.0
或者这是新的bug

To Reproduce

/gamerule randomTickSpeed 100000
然后准星指向任意方块

Expected behavior

FPS不下降到0

Log

No response

Latest CI build tested

  • I confirm that this problem still exists with the latest CI build.
@roj234 roj234 added the type: bug Something isn't working label Feb 2, 2023
@roj234
Copy link
Author

roj234 commented Feb 2, 2023

cc10e14可以复现

@hexadecimal233
Copy link

不考虑优化一下吗,1.20.1成功复现
image

@Hendrix-Shen
Copy link
Collaborator

是否尝试过启用 容器预览时使用缓存(inventoryPreviewUseCache) 选项?

@hexadecimal233
Copy link

关了,看代码ClientTick的末尾会无视任何设置遍历所有世界里的容器然后把游戏给弄得很卡

@roj234
Copy link
Author

roj234 commented Jul 24, 2023

getChunk在单人下会和本地服务端同步区块,如果本地服务端的TPS小于20客户端的tick就会等服务端赶上
PS: mixin掉!doge

Hendrix-Shen added a commit that referenced this issue Jul 24, 2023
Signed-off-by: Hendrix-Shen <HendrixShen@hendrixshen.top>
@Hendrix-Shen
Copy link
Collaborator

目前调整下 endClientTick 空跑 HitResult 的问题。 这个tick warp之后按住容器预览键 Tweakeroo 原生逻辑也是会影响FPS的。

@Hendrix-Shen Hendrix-Shen added resolution: wontfix This will not be worked on label: external issues External Issues labels Aug 3, 2024
@Hendrix-Shen Hendrix-Shen closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
label: external issues External Issues resolution: wontfix This will not be worked on type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants