initial deployment #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorengordon
requested changes
Dec 26, 2023
lorengordon
requested changes
Dec 27, 2023
tests/create_all/main.tf
Outdated
Comment on lines
1
to
2
| module "state_bucket" { | ||
| source = "git::https://github.com/plus3it/terraform-aws-tardigrade-s3-bucket.git?ref=5.0.0" |
There was a problem hiding this comment.
This isn't testing this module at all. It's just invoking the remote s3 module. Every test config should, at least once, invoke this module using a local relative path... source = "../../"
johnricords
force-pushed
the
initial
branch
2 times, most recently
from
2283036 to
946f0b7
Compare
lorengordon
reviewed
Jan 17, 2024
main.tf
Outdated
Comment on lines
60
to
70
| resource "aws_dynamodb_table" "this" { | ||
| name = var.backend_config.dynamodb_table.name | ||
| deletion_protection_enabled = var.backend_config.dynamodb_table.deletion_protection_enabled | ||
| billing_mode = var.backend_config.dynamodb_table.billing_mode | ||
| } |
There was a problem hiding this comment.
Did some research and figured out the error. There are a couple more arguments that are required by the CreateTable API. Not sure why the terraform resource doesn't enforce this directly. Try this:
Suggested change
| resource "aws_dynamodb_table" "this" { | |
| name = var.backend_config.dynamodb_table.name | |
| deletion_protection_enabled = var.backend_config.dynamodb_table.deletion_protection_enabled | |
| billing_mode = var.backend_config.dynamodb_table.billing_mode | |
| } | |
| resource "aws_dynamodb_table" "this" { | |
| name = var.backend_config.dynamodb_table.name | |
| deletion_protection_enabled = var.backend_config.dynamodb_table.deletion_protection_enabled | |
| billing_mode = var.backend_config.dynamodb_table.billing_mode | |
| hash_key = "LockID" | |
| attribute { | |
| name = "LockID" | |
| type = "S" | |
| } | |
| } |
lorengordon
reviewed
Jan 18, 2024
main.tf
Outdated
| name = var.backend_config.dynamodb_table.name | ||
| deletion_protection_enabled = var.backend_config.dynamodb_table.deletion_protection_enabled | ||
| billing_mode = var.backend_config.dynamodb_table.billing_mode | ||
| hash_key = "backend" |
There was a problem hiding this comment.
The value here is critical. It must be LockID.
Suggested change
| hash_key = "backend" | |
| hash_key = "LockID" |
lorengordon
reviewed
Jan 18, 2024
main.tf
Outdated
| hash_key = "backend" | ||
|
|
||
| attribute { | ||
| name = "backend" |
There was a problem hiding this comment.
Same...
Suggested change
| name = "backend" | |
| name = "LockID" |
lorengordon
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.