Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports configuring the option to block public sharing of ebs snapshots #8

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

lorengordon
Copy link
Member

@lorengordon lorengordon commented Sep 20, 2024

PR implementing in the aws provider: hashicorp/terraform-provider-aws#34347

@lorengordon
Copy link
Member Author

Results of make test:

❯ make terraform/pytest PYTEST_ARGS="-v --nomock"
[bootstrap]: Using external tardigrade-ci, skipping auto-init
[pytest//home/x/git/repos/tardigrade-ci/tests/terraform_pytest] Starting Python tests found under the directory "/home/x/git/repos/tardigrade-ci/tests/terraform_pytest"
pytest /home/x/git/repos/tardigrade-ci/tests/terraform_pytest -v --nomock
=========================== test session starts ===========================
platform linux -- Python 3.8.18, pytest-8.2.2, pluggy-1.5.0 -- /home/x/.pyenv/versions/3.8.18/bin/python3.8
cachedir: .pytest_cache
rootdir: /home/x/git/repos
collected 2 items

../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[defaults] PASSED                                                                                                                                          [ 50%]
../tardigrade-ci/tests/terraform_pytest/test_terraform_install.py::test_modules[all-inputs] PASSED                                                                                                                                        [100%]

=========================== 2 passed in 45.34s ============================
[pytest//home/x/git/repos/tardigrade-ci/tests/terraform_pytest]: Tests executed!

@lorengordon lorengordon requested a review from a team September 20, 2024 17:51
Copy link

@yiltis-p3 yiltis-p3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--approved!

@lorengordon lorengordon merged commit eea3dd1 into plus3it:main Sep 20, 2024
4 of 5 checks passed
@lorengordon lorengordon deleted the feat/ebs-public-snapshots branch September 20, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants