Uses builtin salt lgpo functions, removing external lgpo utility #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The terrafirm logs are here, so you can see it is working: Due to plus3it/terrafirm#63, the codebuild jobs are not succeeding, but watchmaker is actually completing. |
YakDriver
approved these changes
Mar 18, 2020
|
The standalone's have always had to download Apply_LGPO_Delta.exe. That was done by the salt state, it was not part of the watchmaker standalone package. Similar to how salt is not itself part of the watchmaker standalone package... However, this set of patches is removing the need for Apply_LGPO_Delta.exe entirely... |
Workaround for saltstack/salt#56288
Without this, for example, Disabled is accepted but 0 results in a validation error. With this both 0 and Disabled will work. Disabled/0 are just examples. The code will actually lookup the acceptable values using the policy information maintained in the lgpo execution module.
Also adds option to output policy details to help identify valid values for all valid secedit policies
An empty string/list is used to clear the user privileges.
The salt builtin `_policyFileReplaceOrAppend()` has bugs when the regpol file has DELETE policies, where it does not properly match or replace the target policy. This patch replaces `_policyFileReplaceOrAppend()` with a pure regex-based solution that will properly match an existing policy in the regpol file, regardless of the policy type (add value, delete value, or delete all values)
This reverts commit ce9907b. The workaround for __context__ is no longer necessary since the patch is in the vendored win_lgpo.py module.
|
Going to merge this and the terrafirm pr, then kick dependabot on watchmaker to update the submodule and get a good run of the tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29