Migrate to zspell-next for the next release #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work on basic parsers
Adding tests Update parsers, further tests passing Finished parser basics, simple test works Corrected pattern, tests pass Updated parsers, line number tests passing
Some error refactoring
Added condition checkers [no ci] Reworked error types [no ci] Update regex formatting Tests passing for condition checking & pattern apply apply_pattern now working for RuleGroup
Basic word creation test working Added some benchmark functions Updated datastructure bench Added benchmark results [no ci]
Update borrowed implementations Add some more methods, update clippy Update tests
Project refactoring Type refactoring [no ci] Work on affix creation Check passed Test checks work [no ci]
tgross35
force-pushed
the
30-zspell-next
branch
from
227fcb8 to
80ea46f
Compare
Fixed clippy lints All tests except builder passed Refactored, check passed Work on tests
Work on updating CLI Spellchecker CLI compiles Basic suggestions working!
Updated doc wording
tgross35
force-pushed
the
30-zspell-next
branch
from
4b8ebd7 to
8af505a
Compare
|
At this point, our structure is pretty well set so I'm good to merge this into main. We can make an alpha release there |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
The goal here is to take lessons learned to redesign our tool for more flexibility.
I will attempt to keep the main API surface consistent, but a lot of currently public types & fields will go private